Fedora 30 Self-Contained Change proposal: Make ambiguous python shebangs error

[Petr Viktorin]

https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error
    == Summary ==
    The <code>/usr/lib/rpm/redhat/brp-mangle-shebangs</code> buildroot
    policy script will be changed to make the build fail when it sees an
    ambiguous python shebang, such as <code>#!/usr/bin/python</code> or
    <code>#!/usr/bin/env python</code>. (The script has been warning in
    these cases for 2 Fedora releases already, saying ''This will become
    an ERROR''.)
Why can't we add something like
`MANGLE_UNVERSIONED_PYTHON_TO=%{__python3}`?

If %_mangle_python_shebnags_to is set, the script will mangle to that
(unless it's unversioned python again or otherwise invalid).
If %_mangle_python_shebnags_to is not set (the default), the script
will error (as currently proposed).

Hmm... Given that upstream PEP 394 allows unversioned "python" for
py2/py3 straddling code, maybe the name could be even shorter?
Maybe what we need is just a way to say the package(r) is aware of
python3 and the latest (as of now) upstream recommendations. With that
info, mangling "/usr/bin/env python" to "/usr/bin/python3" is the right
thing to do.

Probably %_mangle_unversioned_python_shebnags_to becasue that's the only

^^
BTW, if you copy/paste this, be aware there^^ is a typo :)

thing that would be changed.

_______________________________________________
python-devel mailing list -- python-***@lists.fedoraproject.org
To unsubscribe send an email to python-devel-***@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/

[Miro Hrončok]

Post by Petr Viktorin

https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error
    == Summary ==
    The <code>/usr/lib/rpm/redhat/brp-mangle-shebangs</code> buildroot
    policy script will be changed to make the build fail when it sees an
    ambiguous python shebang, such as <code>#!/usr/bin/python</code> or
    <code>#!/usr/bin/env python</code>. (The script has been warning in
    these cases for 2 Fedora releases already, saying ''This will become
    an ERROR''.)
Why can't we add something like
`MANGLE_UNVERSIONED_PYTHON_TO=%{__python3}`?

If %_mangle_python_shebnags_to is set, the script will mangle to that
(unless it's unversioned python again or otherwise invalid).
If %_mangle_python_shebnags_to is not set (the default), the script
will error (as currently proposed).

Hmm... Given that upstream PEP 394 allows unversioned "python" for
py2/py3 straddling code, maybe the name could be even shorter?
Maybe what we need is just a way to say the package(r) is aware of
python3 and the latest (as of now) upstream recommendations. With that
info, mangling "/usr/bin/env python" to "/usr/bin/python3" is the right
thing to do.

Probably %_mangle_unversioned_python_shebnags_to becasue that's the only

                                           ^^
BTW, if you copy/paste this, be aware there^^ is a typo :)

thing that would be changed.

As Vít pointed out, this is getting needlessly complicated. The packager
can fix the shebang with a oneliner. Let them do that instead of adding
an RPM specific oneliner with weird macro definition.

--
Miro Hrončok